Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use PORTFOLIO_VIEW flag to determine token list polling #28579

Merged
merged 5 commits into from
Nov 20, 2024
Merged

fix: use PORTFOLIO_VIEW flag to determine token list polling #28579

merged 5 commits into from
Nov 20, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 20, 2024 •
edited
Loading

Description

Updates the token list hook to only poll across chains when PORTFOLIO_VIEW is set.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. With PORTFOLIO_VIEW=1, requests should go to the token api across all chains.
  2. Without PORTFOLIO_VIEW=1, requests should go to the token api on the current chain.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron marked this pull request as ready for review November 20, 2024 21:56
@bergeron bergeron requested a review from a team as a code owner November 20, 2024 21:56
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

darkwing
darkwing previously approved these changes Nov 20, 2024
View reviewed changes
@bergeron bergeron enabled auto-merge November 20, 2024 21:58
@bergeron
Copy link
Contributor Author

fixing e2e

@bergeron bergeron added this pull request to the merge queue Nov 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [5e9487a]
Page Load Metrics (1853 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35221161784343165
domContentLoaded1610199818149244
load1659206418539847
domInteractive16209544019
backgroundConnect785432110
firstReactRender643811277235
getState46818189
initialActions01000
loadScripts1170152813398641
setupStore687192411
uiStartup19532444211512359
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 34 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit d440363 Nov 20, 2024
75 checks passed
@bergeron bergeron deleted the brian/tokenlistpolling branch November 20, 2024 23:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gambinish gambinish gambinish approved these changes

@darkwing darkwing darkwing approved these changes

Assignees
No one assigned
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bergeron @metamaskbot @darkwing @gambinish